Pref controller: prevent false-positive 'dirty' flag #4721
Conversation
src/controllers/dlgprefcontroller.h
Outdated
| @@ -117,5 +117,6 @@ class DlgPrefController : public DlgPreferencePage { | |||
| QSortFilterProxyModel* m_pInputProxyModel; | |||
| ControllerOutputMappingTableModel* m_pOutputTableModel; | |||
| QSortFilterProxyModel* m_pOutputProxyModel; | |||
| bool m_bGuiInitialized; | |||
There was a problem hiding this comment.
Many other preferences pages call slotUpdate() during the constructor which actually initializes the GUI. Here we wait for the first slotUpdate signal, which happens later, I guess. Did you investigate the reason? If yes a comment would be helpful.
The different behaviours is probably one cause that this issue has happened.
But, this is a good band aid fix anyway. Thank you.
For me it would be more clear to rename the variable to something like.
m_initalUpdate; (without b, we have no convention for a b prefix btw).
There was a problem hiding this comment.
Many other preferences pages call slotUpdate() during the constructor which actually initializes the GUI. Here we wait for the first slotUpdate signal, which happens later, I guess.
I'm afraid that pattern is not consistent and startup time is currently prolonged for no good reasons: unrelated/inadequate actions are triggered in slotUpdate, like writing to config, see #4667 (46b690e).
I'll continue cleaning up the preferences pages one by one.
In general, if slotUpdate is clean (only updates the GUI) it's called every time the Preferences are shown, so it doesn't make sense to me to call it during construction, that would only be repepetive.
I picked m_GuiInitialized so we can use
if (m_GuiInitialized) {..
instead of the negation
if (!m_InitialUpdate) {..
ronso0
force-pushed
the
pref-controller-dirty-fix
branch
from
3ad163a
to
9ebad00
Compare
|
I removed a redundant |
|
@daschuer Please take another look, it's ready for merge IMO |
|
Still Looks and works good. Thank you. |
|
Thanks for the quick review! I'll take care of merging to main. |
Less headaches, finally.
Fixes https://bugs.launchpad.net/mixxx/+bug/1920844
Current behaviour is annoying if you use a mapping script
init()to initialize deck / mixer / effect controls because those controls get re-initialized (= reset) when clicking Okay in the Preferences,.. which was kicking me 'off my horse' during live sets more than once.See first commit for details.